Skip to content

Commit

Permalink
Move away from dependency pinning anyway
Browse files Browse the repository at this point in the history
It's a bit hard to decide. I have repeatedly changed this in the past.
New approach:
* Comment out pinning in pyproject.toml to speed up installation with
build isolation, and to retain default compatibility with older pythons
* Keep pinning ctypesgen in the workflow, but don't pin wheel anymore
  • Loading branch information
mara004 committed Sep 13, 2022
1 parent 5c53604 commit 8687c37
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ jobs:
- name: Install/update dependencies
run: |
python3 -m pip install -U pip
python3 -m pip install -U setuptools setuptools-scm build
python3 -m pip install --force-reinstall git+https://github.com/pypa/wheel.git@9d4264d2f23ea44dd85639a27fa6b284261921cd
python3 -m pip install -U setuptools setuptools-scm build wheel
python3 -m pip install git+https://github.com/ctypesgen/ctypesgen.git@master
python3 -m pip install -U .[utilities,test,inserttext,converters]
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ requires = [
"setuptools",
"setuptools-scm",
"build",
"wheel @ git+https://github.com/pypa/wheel.git@9d4264d2f23ea44dd85639a27fa6b284261921cd", # or @main
"ctypesgen @ git+https://github.com/ctypesgen/ctypesgen.git@master",
"wheel", # @ git+https://github.com/pypa/wheel.git@9d4264d2f23ea44dd85639a27fa6b284261921cd # or @main
"ctypesgen", # @ git+https://github.com/ctypesgen/ctypesgen.git@master
]

0 comments on commit 8687c37

Please sign in to comment.