Skip to content

Commit

Permalink
PR template nits
Browse files Browse the repository at this point in the history
  • Loading branch information
mara004 committed Nov 21, 2023
1 parent 100d7e4 commit a5f2c5b
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,32 @@
**Important:** External contributors are urged to comply with the template.


## Description

<!-- Explain your changes -->


## Checklist

<!--
- Choose the section(s) relevant to your PR and answer the questions. A section is indicated by ### Heading.
- Choose the section(s) relevant to your PR and answer the questions. A section is indicated by `### Heading`.
- Non-applying sections can be ignored or removed.
- Place an `x` in the `[ ]` for "yes", leave it empty for "no". If a question is not applicable, remove the `[ ]`, but keep the question in place.
- Place an `x` in the [ ] for yes, leave it empty for no. If a question is not applicable, remove the [ ], but keep the message in place.
- Use the Preview tab to confirm the PR will render correctly.
-->


### Setup

- [ ] This PR changes setup code (`setupsrc/`, `setup.py` etc.).
- [ ] I have tested the change does not break internal callers.
- [ ] I believe the change is maintainable and does not cause unreasonable complexity or code pollution.
- [ ] If acting on behalf of a downstream use case, I have assessed that it cannot reasonably be solved by existing means, or the change forms a notable improvement over possible alternatives.
- [ ] I believe the targeted use case is supported by pypdfium2-team. *Note that we might not want to support esoteric or artificially restricted setup envs.*

- [ ] I believe the targeted use case is supported by pypdfium2-team. *Note that we may not want to support esoteric or artificially restricted setup envs.*

### Helpers

- [ ] This PR changes helpers code.
- [ ] The change comes with sufficient test cases to confirm correct functionality.
- [ ] Any new test files are under a suitable license and have been registered in `reuse/dep5`.


### Other

- [ ] This PR changes other things, namely: ... <!-- briefly specify what was changed -->

0 comments on commit a5f2c5b

Please sign in to comment.