Skip to content

Commit

Permalink
wheel tags: adjust minimum required macOS version
Browse files Browse the repository at this point in the history
  • Loading branch information
mara004 committed Sep 5, 2022
1 parent 0d6f2e9 commit e9adc16
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions setupsrc/pl_setup/setup_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def _get_tag(pl_name):
# pip>=20.3 now accepts macOS wheels tagged as 10_x on 11_x. Not sure what applies to 12_x.
# Let's retain multi-version tagging for broader compatibility all the same.
if pl_name == PlatformNames.darwin_x64:
# pdfium-binaries/steps/05-configure.sh defines `mac_deployment_target = "10.11.0"`
return _get_mac_tag("x86_64", "10_11", "11_0", "12_0")
# pdfium-binaries/steps/05-configure.sh defines `mac_deployment_target = "10.13.0"`
return _get_mac_tag("x86_64", "10_13", "11_0", "12_0")
elif pl_name == PlatformNames.darwin_arm64:
return _get_mac_tag("arm64", "11_0", "12_0")
elif pl_name == PlatformNames.linux_x64:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_entrypoint():
# setup_base

ExpectedTags = (
(PlatformNames.darwin_x64, "macosx_10_11_x86_64.macosx_11_0_x86_64.macosx_12_0_x86_64"),
(PlatformNames.darwin_x64, "macosx_10_13_x86_64.macosx_11_0_x86_64.macosx_12_0_x86_64"),
(PlatformNames.darwin_arm64, "macosx_11_0_arm64.macosx_12_0_arm64"),
(PlatformNames.linux_x64, "manylinux_2_17_x86_64.manylinux2014_x86_64"),
(PlatformNames.linux_x86, "manylinux_2_17_i686.manylinux2014_i686"),
Expand Down

0 comments on commit e9adc16

Please sign in to comment.