Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference bindings file to repository #192

Closed
mara004 opened this issue Mar 22, 2023 · 0 comments · Fixed by #196
Closed

Add reference bindings file to repository #192

mara004 opened this issue Mar 22, 2023 · 0 comments · Fixed by #196
Assignees
@mara004
Labels
enhancement New feature or request minor Low importance

Comments

@mara004
Copy link
Member

mara004 commented Mar 22, 2023 •
edited
Loading

Want to add a reference bindings file to the repository and update it on autorelease.

Advantages

  • tracks additions/deletions in pdfium, as well as changes to bindings generation
  • the bindings are made visible in the repository, on the web (makes things slightly more transparent/obvious)
  • embedders who don't get ctypesgen running for some reason, but still wish to install from source (e. g. to get newer code than the latest release), are provided with a bindings file that is easy to find and use (as opposed to extracting one from a wheel)
@mara004 mara004 added the enhancement New feature or request label Mar 22, 2023
@mara004 mara004 self-assigned this Mar 22, 2023
@mara004 mara004 added the minor Low importance label Mar 22, 2023
@mara004 mara004 linked a pull request Mar 23, 2023 that will close this issue
Add reference bindings (closes #192) #196
Merged
mara004 added a commit that referenced this issue Mar 23, 2023
@mara004
Add reference bindings (closes #192) (#196)
71a0a63
@mara004 mara004 mentioned this issue Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mara004 mara004

Labels
enhancement New feature or request minor Low importance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add reference bindings (closes #192) pypdfium2-team/pypdfium2
1 participant
@mara004