Automatically close objects via __del__
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mara004
commented
Sep 24, 2022
| @@ -188,8 +188,6 @@ def test_open_new(): | |||
|
|
|||
|
|
|||
| def test_open_invalid(): | |||
| with pytest.raises(TypeError, match=re.escape("__init__() missing 1 required positional argument: 'input_data'")): | |||
| pdf = pdfium.PdfDocument() | |||
There was a problem hiding this comment.
Removed this test case because it doesn't check anything pypdfium2-specific. This is common Python behaviour.
Thereby, we avoid an "unraisable exception" warning when running tests (__del__ is still called, even if initialisation failed due to a parameter error handled by Python and the actual constructor code was never reached).
There was a problem hiding this comment.
Hmm, theoretically, we could add some hasattr() check to suppress these warnings, but I don't think that's worth it, given that this only happens in case of serious API misuse.
This avoids an additional variable. Nice side effect: Most PDFium methods have checks against passing in nullptr (None). If callers try to use an object after its `.raw` attribute has been set to None, now nothing should happen (as opposed to a segmentation fault). Also, it's good to remove the reference to the ctypes representation on close() to directly enqueue it for being discarded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.