Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init_forms: call FPDF_LoadXFA() as necessary (CC #221, #222) #223

Merged
merged 1 commit into from
Jun 6, 2023
Merged

init_forms: call FPDF_LoadXFA() as necessary (CC #221, #222) #223

merged 1 commit into from
Jun 6, 2023

Conversation

mara004
Copy link
Member

@mara004 mara004 commented May 30, 2023

No description provided.

@mara004 mara004 marked this pull request as ready for review May 30, 2023 11:23
@mara004 mara004 linked an issue May 30, 2023 that may be closed by this pull request
XFA not initialized in init_forms() #222
Closed
mara004
mara004 commented May 31, 2023
View reviewed changes
src/pypdfium2/_helpers/document.py Outdated
raw = pdfium_c.FPDFDOC_InitFormFillEnvironment(self, config)
if not raw:
raise PdfiumError(f"Initializing form env failed for document {self}.")
self.formenv = PdfFormEnv(raw, config, self)

if V_PDFIUM_IS_V8 and formtype in (pdfium_c.FORMTYPE_XFA_FOREGROUND, pdfium_c.FORMTYPE_XFA_FULL):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: want to swap FORMTYPE_XFA_FOREGROUND and FORMTYPE_XFA_FULL

@mara004 mara004 force-pushed the main branch 2 times, most recently from 0129609 to 69b3880 Compare June 1, 2023 13:37
@mara004
Call FPDF_LoadXFA() in init_forms(), warn on error
40b8376 
FPDF_LoadXFA() currently seems to be broken in pdfium-binaries.
All the same, add the call so that pypdfium2 is prepared for an
eventual upstream fix.

Currently this only warns on error. Once the aforementioned issue
is fixed, it should be tightened to a PdfiumError exception.

See also #221 #222
@mara004 mara004 merged commit e5d348e into main Jun 6, 2023
@mara004 mara004 deleted the xfa branch June 6, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XFA not initialized in init_forms()
1 participant
@mara004