This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Extract review aspect ratio scale is calculated by ffmpeg #3620
+6
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antirotor
approved these changes
Aug 5, 2022
This was referenced Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Ratio scaling calculations happens in ffmpeg instead of our python code.
Description
It happened that
1080after python float calculations becomes1081which cause a lot of troubles. The main reason why we did that was to keep aspect ratio but ffmpeg scale hasforce_original_aspect_ratiooption which keep ration by decreasin or increasing (in our case decreasing) and calculate padding difference in ffmpeg too.Additional info
This is huge change and should be tested properly. Changes affect cases when scale is needed and when input and output have different aspect ratio (scale is needed).
Testing notes:
Force extract review to output a video which has different aspect ratio (visible with an eye) then converted input. The output should have right resolution and should be padded the right way.