Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Extract Review can scale with pixel aspect ratio #3644

Merged

Conversation

iLLiCiTiT
Copy link
Member

Brief description

This PR removed ability to scale source using pixel aspect ratio which is fixed here.

Description

Next paragraf is more elaborate text with more info. This will be displayed for example in collapsed form under the first sentence in a changelog.

Additional info

The rest will be ignored in changelog and should contain any additional
technical information.

Testing notes:

  1. Make sure project_settings/global/publish/ExtractReview/profiles/0/outputs/h264/scale_pixel_aspect is set to true
  2. Publish something with pixel aspect ratio different then 1
  • from what I know it's possible from nuke or editorial
  • e.g. anamorphic image (pixel aspect is 2 so 100x100 should have resolution 200x100)
  1. Check output which should be scaled as expected

Resolves #3641

@ynbot
Copy link
Contributor

ynbot commented Aug 10, 2022

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 10, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Aug 10, 2022
Copy link
Collaborator

@jrsndl jrsndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. I tested in Nuke 12.2v3, on 2:1 anamorphic, with local publish.

With Scale pixel aspect off, the burnin pixel aspect doesn't match the pixel aspect of the image. I take it as a current limitation.
image

@iLLiCiTiT iLLiCiTiT merged commit b88e537 into develop Aug 15, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-3719_Extract-Review-does-not-scale-to-pixel-ratio branch August 15, 2022 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Review does not scale to pixel ratio
3 participants