OIDC: Configurable audience #13140
Merged
OIDC: Configurable audience #13140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `OIDC_AUDIENCE` + `warehouse.oidc.audience` to allow a Warehouse deployment to vary its expected OIDC audience. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
commented
Mar 6, 2023
| @@ -32,7 +32,7 @@ class InsecureOIDCPublisherWarning(UserWarning): | |||
|
|
|||
| @implementer(IOIDCPublisherService) | |||
| class NullOIDCPublisherService: | |||
| def __init__(self, session, publisher, issuer_url, cache_url, metrics): | |||
| def __init__(self, session, publisher, issuer_url, audience, cache_url, metrics): | |||
There was a problem hiding this comment.
NB: I didn't bother making NullOIDCPublisherService respect the varied audience, since it's development-only and explicitly doesn't perform a full verification.
di
approved these changes
Mar 6, 2023
|
I've set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12465.
This allows instances like TestPyPI to configure their own OIDC audience.