feat(admin): Project Quarantine #16179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
added
HTML
miketheman
force-pushed
the
miketheman/quarantine-project
branch
from
38055e2 to
b7ead57
Compare
ewdurbin
reviewed
Jun 27, 2024
warehouse/migrations/versions/c978a4eaa0f6_add_observation_related_name.py
Show resolved
Hide resolved
warehouse/migrations/versions/14ad61e054cf_add_project_lifecycle_status.py
Show resolved
Hide resolved
miketheman
force-pushed
the
miketheman/quarantine-project
branch
3 times, most recently
from
4ab2b82 to
acdd6bf
Compare
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
The migration ran in production in April. Using ORM objects in migrations is apparently dangerous for tests, since we run the entire migration stack from scratch, and **later** modifications to a model are not available at the point this migration is being executed. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
A button that re-uses the malware routes. We can create bespoke routes and views for quarantine manipulation if we find that using this feature leads to confusing redirects, but for now I'm opting for simpler implementation. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/quarantine-project
branch
from
c607f4a to
5919087
Compare
ewdurbin
approved these changes
Jul 2, 2024
di
reviewed
Jul 5, 2024
woodruffw
reviewed
Jul 8, 2024
woodruffw
reviewed
Jul 8, 2024
woodruffw
reviewed
Jul 8, 2024
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Jul 8, 2024
4 seconds wasn't long enough to get the lock on `projects`. Refs: pypi#16179 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes introduces a concept of Project Lifecycle Status, and specifically adding and removing projects from a quarantine status.
There are no end-user facing changes yet, and those will only be introduced after this PR is merged/deployed (so there's no race condition with ORM changes and columns not existing in time...)
The intent is to have a status that can convey that we are not certain if a project is good or bad yet - but it's concerning enough that we want to make in unavailable to installers or mirrors. Those changes will follow later.
This is mostly to get a feel for how it will work on the Project's model and how things enter and exit quarantine.
Admin Interface for Quarantine 👩💻 - Watch Video