Check OIDC issuer claim when verifying uploaded PEP740 attestations #16860
+35
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the PEP-740 attestations uploaded via Trusted Publishing, to make sure that the OIDC issuer in the certificate matches the OIDC issuer used for Trusted Publishing. Since we currently only support uploading attestations via GitHub Actions, that's the only provider we need to modify.
There are two commits, the first one moves the
*_OIDC_ISSUER_URLconstants fromoidc/utils.pyto their corresponding model file (oidc/models/{github,gitlab,etc}.py), in order to be able to use them inside the models (otherwise it's a circular import).The second commit adds the check discussed in the first paragraph.
cc @woodruffw @di