Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rudimentary verdicts view. Progress on #6062. #7207

Merged
merged 4 commits into from
Jan 10, 2020
Merged

Add rudimentary verdicts view. Progress on #6062. #7207

merged 4 commits into from
Jan 10, 2020

Commits on Jan 9, 2020

  1. Add rudimentary verdicts view. Progress on #6062. 

    Also, add some better testing logic for wiped_out condition.
    @xmunoz
    xmunoz committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    c55d0d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Code review changes. 

    - Conditionally show fields that are populated
- JSON pretty formatting
    @xmunoz
    xmunoz committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    a26a5b5 View commit details
    Browse the repository at this point in the history

  2. Fix unit test bug. 

    - Use `get` instead of `filter` to look up verdict by pkey.
    @xmunoz
    xmunoz committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    9c980f7 View commit details
    Browse the repository at this point in the history

  3. simplify unit tests for verdicts view

    @xmunoz
    xmunoz committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    912cab4 View commit details
    Browse the repository at this point in the history