Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: 1 test failure for release 3.4.0 on Fedora 37 and 36. #1141

Closed
jdkloe opened this issue Sep 11, 2022 · 3 comments · Fixed by #1148
Closed

TST: 1 test failure for release 3.4.0 on Fedora 37 and 36. #1141

jdkloe opened this issue Sep 11, 2022 · 3 comments · Fixed by #1148
Labels
test Test related issues
Milestone

Comments

@jdkloe
Copy link
Contributor

jdkloe commented Sep 11, 2022

Code Sample, a copy-pastable example if possible

Yesterdays 3.4.0 release builds and tests just fine in Fedora rawhide (future fedora 38).
However, the test suite produces one test failure when run with: py.test-3 -m "not network" for fedora 37 and 36.
I can suppress this test by using "not network and not grid", but if possible, I think it would be better to understand what is going on and to fix it if possible

The output for the failing test is:

__________________ test_transformer_group__get_transform_crs ___________________
    @pytest.mark.grid
    def test_transformer_group__get_transform_crs():
        tg = TransformerGroup("epsg:4258", "epsg:7415")
        if not grids_available("nl_nsgi_rdtrans2018.tif"):
>           assert len(tg.transformers) == 1
E           assert 2 == 1
E            +  where 2 = len([<Concatenated Operation Transformer: pipeline>\nDescription: Inverse of Transformation from NAP height to ETRS89 (ball...geographic offset from Amersfoort to ETRS89 + RD New\nArea of Use:\n- name: World\n- bounds: (-180.0, -90.0, 180.0, 90.0)])
E            +    where [<Concatenated Operation Transformer: pipeline>\nDescription: Inverse of Transformation from NAP height to ETRS89 (ball...geographic offset from Amersfoort to ETRS89 + RD New\nArea of Use:\n- name: World\n- bounds: (-180.0, -90.0, 180.0, 90.0)] = <TransformerGroup: best_available=False>\n- transformers: 2\n- unavailable_operations: 4.transformers
test/test_transformer.py:699: AssertionError 

Version details for fedora 37 are:
pyproj release 3.4.0
proj version 9.0.1
python3 version 3.11.0~rc1
gcc version 12.2.1
python3-Cython version 0.29.32

Version details for fedora rawhide/38 are:
pyproj release 3.4.0
proj version 9.1.0
python3 version 3.11.0~rc1
gcc version 12.2.1
python3-Cython version 0.29.32

The only difference seems to be the version of the proj library.

For more details see:
https://koji.fedoraproject.org/koji/buildinfo?buildID=2061414 (rawhide build)
https://koji.fedoraproject.org/koji/taskinfo?taskID=91901918 (fedora 37 build)

@jdkloe jdkloe added the bug label Sep 11, 2022
@snowman2
Copy link
Member

Possibly related: #1083

@snowman2
Copy link
Member

snowman2 commented Sep 12, 2022

I am currently thinking the tests need to be updated to match #1130

@snowman2
Copy link
Member

@jdkloe, I don't think there is a bug with PROJ. Just a behavior change.

@snowman2 snowman2 changed the title 1 test failure for release 3.4.0 on Fedora 37 and 36. TST: 1 test failure for release 3.4.0 on Fedora 37 and 36. Sep 17, 2022
@snowman2 snowman2 added test Test related issues and removed bug labels Sep 17, 2022
@snowman2 snowman2 added this to the 3.4.1 milestone Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test related issues
Projects
None yet
2 participants