Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solid biomass for industry demand #249

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

energyLS
Copy link
Collaborator

@energyLS energyLS commented Dec 4, 2023

Closes #247

Changes proposed in this Pull Request

See explaination in #247.

"Peat" could be discussed on where to assign, I think coal makes sense.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@energyLS energyLS changed the title fix: assign fuels correctly Fix solid biomass for industry demand Dec 4, 2023
@energyLS energyLS requested a review from hazemakhalek December 4, 2023 10:46
scripts/helpers.py Outdated Show resolved Hide resolved
scripts/helpers.py Outdated Show resolved Hide resolved
@energyLS
Copy link
Collaborator Author

energyLS commented Dec 5, 2023

@hazemakhalek I have moved peat to coal, now everything should be ready :)

energyLS added a commit that referenced this pull request Dec 18, 2023
@hazemakhalek hazemakhalek merged commit ca7a778 into main Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misclasification of fuels to biomass in industry sector
2 participants