Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run africa with updated csvs (DO NOT MERGE) #286

Closed
wants to merge 13 commits into from
Closed

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Feb 8, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@doneachh
Copy link
Collaborator

doneachh commented Mar 7, 2024

Hi @davide-f ! :)
We could probably delete this PR, if we merge #292 in #285 .
What do you think? :)

@doneachh doneachh mentioned this pull request Mar 8, 2024
6 tasks
@davide-f
Copy link
Member Author

davide-f commented Mar 8, 2024

Hi @davide-f ! :) We could probably delete this PR, if we merge #292 in #285 . What do you think? :)

I've updated the other PR and running locally Africa, let's see :D

@davide-f
Copy link
Member Author

This can be closed; your code @doneachh worked smoothly :)

@davide-f davide-f closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants