Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type error when converting GADM id #328

Closed
wants to merge 2 commits into from

Conversation

doneachh
Copy link
Collaborator

@doneachh doneachh commented Jun 2, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@doneachh doneachh linked an issue Jun 2, 2024 that may be closed by this pull request
2 tasks
@doneachh doneachh requested review from davide-f and energyLS June 2, 2024 07:05
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @doneachh :D
As comment, is the other issue linked to this?

I'm unsure whether it is a good idea to address the naming conventions before the merge, though it may be good to discuss with the others.

I create an issue that is linked to these issues you've found

@doneachh
Copy link
Collaborator Author

doneachh commented Jun 6, 2024

@davide-f Could be probably linked with the other issue (with len(x)) as i used the same config for the run

@doneachh doneachh mentioned this pull request Jun 9, 2024
6 tasks
@doneachh
Copy link
Collaborator Author

doneachh commented Jun 9, 2024

@davide-f #326 doesnt fix this here. should we leave it like this or fix it as well with the layer id here? Would probably prefer to make it this way as we dont have redundant code then :)

@davide-f
Copy link
Member

Answered on the other PR, feel free to ping me in discord if I lose it here

@doneachh doneachh closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError in rule prepare_gas_network
2 participants