Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo cleaning #350

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Repo cleaning #350

merged 3 commits into from
Jul 3, 2024

Conversation

hazemakhalek
Copy link
Collaborator

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.

@davide-f
Copy link
Member

davide-f commented Jul 1, 2024

Nice cleaning @hazemakhalek.
Please cite us when review is needed. Currently it looks good.

@hazemakhalek hazemakhalek marked this pull request as ready for review July 3, 2024 08:33
@hazemakhalek hazemakhalek requested a review from davide-f July 3, 2024 08:33
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @hazemakhalek, this looks clean :)

@davide-f davide-f merged commit 9f943e4 into main Jul 3, 2024
5 checks passed
@davide-f davide-f mentioned this pull request Jul 4, 2024
18 tasks
@@ -111,51 +111,6 @@ costs: # Costs used in PyPSA-Earth-Sec. Year depends on the wildcard planning_ho


industry:
St_primary_fraction: 0.9 # fraction of steel produced via primary route versus secondary route (scrap+EAF); today fraction is 0.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for asking post-merge, but don't we need these configs anymore? @hazemakhalek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants