Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tech_colors #1205

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Fix tech_colors #1205

merged 3 commits into from
Dec 2, 2024

Conversation

arizeosalac
Copy link
Contributor

Closes # (if applicable).

Changes proposed in this Pull Request

This PR corrects the values on the "tech_colors" of the config.default.yaml file since the HEX codes for the colors were being identified at the moment as comments instead of being string values.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@ekatef
Copy link
Member

ekatef commented Nov 28, 2024

Hello @arizeosalac!
Thanks a lot for the contribution. To me, it looks like being ready to merge, but would be nice to see that CI is happy. Could you please update your branch to accommodate the latest changes from main? The have been some recent environment fixes which make CI up and running again.

As a little comment, it appears from our discussion with @doneachh the changes you introduce are important to make work example notebooks. This PR should fix these troubles! 😄

@ekatef
Copy link
Member

ekatef commented Nov 29, 2024

@arizeosalac sorry, there is one more point: may you be willing to add a release note? 🙂
That is quite a substantial contribution, and I think it's worth to be mentioned in the release notes 😄

@ekatef ekatef merged commit d727d39 into pypsa-meets-earth:main Dec 2, 2024
6 checks passed
@ekatef
Copy link
Member

ekatef commented Dec 2, 2024

Merged! 🎉
@arizeosalac thank you for the nice work, and welcome to the contributors list 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants