Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace carrier natural gas with respective technology #797

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

energyLS
Copy link
Collaborator

@energyLS energyLS commented Jul 19, 2023

Closes #774

Changes proposed in this Pull Request

Replace carrier "natural gas" with the respective technology (OCGT or CCGT) to align with PyPSA names of "carriers" and avoid filtering "natural gas" powerplants in ppl.query("carrier in @carriers")

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@energyLS energyLS changed the title fix: replace carrier natural gas with technology replace carrier natural gas with respective technology Jul 19, 2023
@energyLS energyLS requested a review from pz-max July 19, 2023 09:01
Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci

@pz-max
Copy link
Member

pz-max commented Jul 19, 2023

Can you add a release note? @energyLS

@energyLS
Copy link
Collaborator Author

Can you add a release note? @energyLS

Sure, I have added it @pz-max

@pz-max pz-max merged commit b8d2bf8 into pypsa-meets-earth:main Jul 19, 2023
@davide-f davide-f mentioned this pull request Aug 21, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conventional Gas Generators get kicked out
2 participants