Skip to content

Commit

Permalink
Merge pull request #2356 from pyrevitlabs/fix-hyperlinkengine-netcore
Browse files Browse the repository at this point in the history
Update HyperlinkEngine.cs
  • Loading branch information
jmcouffin committed Aug 16, 2024
2 parents 56c49bb + d686954 commit 6a2ab4f
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ public override int Execute(ref ScriptRuntime runtime) {
// first argument is expected to be a hyperlink
if (runtime.ScriptRuntimeConfigs.Arguments.Count == 1) {
string hyperLink = runtime.ScriptRuntimeConfigs.Arguments.First();
System.Diagnostics.Process.Start(hyperLink);
Process? process = System.Diagnostics.Process.Start(new ProcessStartInfo(hyperLink){

Check failure on line 21 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

The type or namespace name 'Process' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

The type or namespace name 'Process' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

The type or namespace name 'ProcessStartInfo' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

The type or namespace name 'ProcessStartInfo' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

The type or namespace name 'Process' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

The type or namespace name 'ProcessStartInfo' could not be found (are you missing a using directive or an assembly reference?)
UseShellExecute = true
});
process!.WaitForExit();

Check failure on line 24 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

Feature 'nullable reference types' is not available in C# 7.3. Please use language version 8.0 or greater.

Check failure on line 24 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

Feature 'nullable reference types' is not available in C# 7.3. Please use language version 8.0 or greater.

Check failure on line 24 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

'Process?' does not contain a definition for 'WaitForExit' and no accessible extension method 'WaitForExit' accepting a first argument of type 'Process?' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 24 in dev/pyRevitLabs.PyRevit.Runtime/HyperlinkEngine.cs

View workflow job for this annotation

GitHub Actions / build

'Process?' does not contain a definition for 'WaitForExit' and no accessible extension method 'WaitForExit' accepting a first argument of type 'Process?' could be found (are you missing a using directive or an assembly reference?)
return ScriptExecutorResultCodes.Succeeded;
}
else {
Expand All @@ -38,4 +41,4 @@ public override int Execute(ref ScriptRuntime runtime) {
}
}
}
}
}

0 comments on commit 6a2ab4f

Please sign in to comment.