Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Rules #252

Closed
andrewberes opened this issue Nov 15, 2017 · 6 comments
Closed

Icon Rules #252

andrewberes opened this issue Nov 15, 2017 · 6 comments

Comments

@andrewberes
Copy link

I am having an issue with icons showing up off center and fuzzy even when following the video posted on youTube for downloading them from icons8.

I have the size set to 32px by 32px with a resolution of 72DPI - are there any additional rules for making them appear as they should?

capture

They should appear like this:
icon
icon

Thanks!

eirannejad added a commit that referenced this issue Nov 15, 2017
@eirannejad
Copy link
Collaborator

eirannejad commented Nov 15, 2017

@andrewberes This issue is general with Revit. The icon DPI needs to be 96 for the icons to show up correctly. Previously icons8 didn't include DPI in their PNG files but recently they PNG generate system has changed and it adds odd DPIs to the PNGs.

I fixed this issue under the develop branch and I just pushed that as a hotfix to the master. Update your pyRevit and the icons should load correctly. pyRevit now scales the icons based on the required size for the button and the image DPI

This change has two benefits:

  • You can download icons from any source and use them with pyRevit with no DPI change.
  • Icons larger than 32x32 can be used for better icon sharpness on hi-res displays. I'm using 128x128 icons on some of the custom company tools and they look much sharper on my hi-res screen

@eirannejad
Copy link
Collaborator

@gtalarico

@andrewberes
Copy link
Author

Awesome! Thanks for the quick response - pyRevit has become by far my most useful add-in. It makes it easy for a beginner to quickly develop custom tools with basic python knowledge! Thanks for all your work!

@eirannejad
Copy link
Collaborator

Exactly. That was my main motive behind it. All the pyRevit tools are basically a showcase of the python programming for Revit. pyRevit to me is really a rapid-prototyping and development environment.

Thanks for your support.

@Antonj123
Copy link

Hi Guys,
Sorry to as this question,,, yes i know its a silly one.
I love the coloured icons but i dnt know how i can change them.
Any chance you can explain this to a newbe like me?
Thanks you.

@baldeModeler
Copy link

Hi,
I am on Revit 2024 but there the icon pyRevit doesn't display. I have changed 32x32 pixel and 96x96 pixel also? thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants