Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/preflight #1103

Merged
merged 5 commits into from
Jan 8, 2021
Merged

Feature/preflight #1103

merged 5 commits into from
Jan 8, 2021

Conversation

jmcouffin
Copy link
Contributor

@jmcouffin jmcouffin commented Dec 21, 2020 •
edited
Loading

Hi there,
Worked a bit on the structure.
I added the RVT links count and list and also the pinned status count.
Got a bit of trouble making the treshold function work:

  • if not all links pinned red
  • if all links pinned green.
    The logic behind the threshold function is not flexible enough in itself to allow for such cases without having to work around it IMHO @davidvadkerti

I think that organizing the report in a more classical way would be having it listed by themes:
image

I have left some output.print_md uncomented to test purposes.

Also, having it in two different setupp prospect:

  1. the ui to setup the type of model check with a list of items to be checked (sheets, links, ...) then being able to save it in the revit file or on the computer
  2. then a single click for the default _ a bit like the shift click.
  3. I would definitely separate all the checks from the displying part of the report.

Could you help with the structure @eirannejad, you are more used to coding complex things than I

@jmcouffin
Added my first check within the modelchecker_check
8059bf0 
RVT Links
@jmcouffin
Landslide
f6de4bf
@jmcouffin
Refac of data collection and dispay
011706e 
I organized the file as follow in order to modularize it later on more easily:
- Collectors
- Thresholds (would like to have it in a separate file to be able to set it differently depending on the size of the project)
- Graphics

all are grouped now

todo:
- thresholds in a config file
- UI with presets: modelchecker big project, model charcker small projects
all grabing the proper thresholds set
@jmcouffin
Copy link
Contributor Author

I put some more work in in with my last commit:
image

@jmcouffin
Copy link
Contributor Author

added refplane count and fixed french version
image

@jmcouffin
Copy link
Contributor Author

I'd be interested getting a first feedback from you @eirannejad @davidvadkerti

@eirannejad eirannejad changed the base branch from feature/preflight to pr/1103 January 8, 2021 17:41
@eirannejad eirannejad merged commit ba70a76 into pyrevitlabs:pr/1103 Jan 8, 2021
@eirannejad
Copy link
Collaborator

Merged into pr/1103 for review. Thank you so much @jmcouffin

@eirannejad
Copy link
Collaborator

I think this is good. I'm merging into develop and we can continue improvements further. I'll also add the author name in the preflight check selector window

@jmcouffin
Copy link
Contributor Author

jmcouffin commented Jan 8, 2021 via email •
edited by eirannejad
Loading

@jmcouffin
Copy link
Contributor Author

jmcouffin commented Jan 8, 2021 via email •
edited by eirannejad
Loading

@jmcouffin
Copy link
Contributor Author

@eirannejad Could you help me a bit on understanding the process for what's following. You merged it to develop. Do I have access to this branch, can I fork it and push PR to it and continue development from there? I am not so familiar with the whole process and I don't want to mess things up.

@eirannejad
Copy link
Collaborator

@jmcouffin Oh yeah! All the repo is open so you can fork and 'checkout' any of the branches you want. I usually follow Git Flow so being familiar with that helps working together better.

Make a branch for the feature or improvements you are working on and continue sending PRs. Keeping the PRs small helps me merge them faster as well.

This is all the usual git collaboration flow. Nothing too specific to pyRevit codebase

@pyrevitlabs pyrevitlabs deleted a comment from jmcouffin Jan 12, 2021
@jmcouffin
Copy link
Contributor Author

@jmcouffin Oh yeah! All the repo is open so you can fork and 'checkout' any of the branches you want. I usually follow Git Flow so being familiar with that helps working together better.

Make a branch for the feature or improvements you are working on and continue sending PRs. Keeping the PRs small helps me merge them faster as well.

This is all the usual git collaboration flow. Nothing too specific to pyRevit codebase

I am not quite there yet in terms of Git Flow.
I did messup things on my computer with github desktop a few minutes ago.
I swithced branch from feature/preflight to develop and could not go back. Deleted everything locally and got the develop branch back on my computer wut I got this error and cannot launch pyrevit in revit now
image

@jmcouffin
Copy link
Contributor Author

jmcouffin commented Jan 12, 2021 •
edited
Loading

I manage to get it back together properly I guess, from my own branch
pyrevit clone pf2 --dest=C:\pyRevit\PFtake2 --source=https://github.com/jmcouffin/pyRevit.git --branch=feature/preflight

kind of @eirannejad the all the css is not rendering properly in my output window. on one side I have the whole pyrevit not loading (develop) on the other (my branch of preflight) all the css does not render in preflight.

what did I do wrong and how to fix it?

@jmcouffin
Copy link
Contributor Author

I tried many ways, the develop branch does not load as per
image
@eirannejad

@eirannejad
Copy link
Collaborator

You need to recompile all the binaries when you are on develop. I just committed the compiled binaries and you can update your develop from mine.

@jmcouffin
Copy link
Contributor Author

jmcouffin commented Jan 12, 2021 via email

@eirannejad
Copy link
Collaborator

@jmcouffin The selector window now looks like this

Screen Shot 2021-01-15 at 9 22 26 AM

@jmcouffin
Copy link
Contributor Author

jmcouffin commented Jan 15, 2021 via email

@jmcouffin
Copy link
Contributor Author

@jmcouffin The selector window now looks like this

Screen Shot 2021-01-15 at 9 22 26 AM

thinking out loud:

  • Maybe there would be more value in adding a description of what will be checked (tooltip like info) than info about the author ;)
  • The structure in itself is perfect for further model_checker templates addition, but for now, maybe the pushbutton is enough?
  • a two column window could allow for model checking template selection and on the right for the description of what is being checked

@eirannejad
Copy link
Collaborator

Ok would you mind expanding the description on your model checker? The description is basically the docstring for the class

class ModelChecker(PreflightTestCase):
    """Revit Model Quality Checker"""
# ...

@jmcouffin jmcouffin mentioned this pull request Jan 19, 2021
Merged
@jmcouffin
Copy link
Contributor Author

Ok would you mind expanding the description on your model checker? The description is basically the docstring for the class

class ModelChecker(PreflightTestCase):
    """Revit Model Quality Checker"""
# ...

see #1127

@davidvadkerti
Copy link
Contributor

I put some more work in in with my last commit:
image

Hi, just to explain my original intent(don't know whether it is relevant): the reason why I packed all "squares" together was to quickly spot red squares without much scrolling.

Hopefully I will have some time to contribute to this tool. You've done a lot since I wasn't here :)

@jmcouffin
Copy link
Contributor Author

jmcouffin commented Feb 9, 2021 via email

@jmcouffin
Copy link
Contributor Author

jmcouffin commented Feb 9, 2021 via email

@davidvadkerti
Copy link
Contributor

davidvadkerti commented Feb 9, 2021 •
edited
Loading

In the tool in my extension all results are logged and then can be analysed in power BI dashboard. I removed this part of code to make the initial pull request easier. I want to add this feature later.
There is also another version of this script adapted for use in Revit Batch Processor. Then you can run it automaticaly on all of your central files every evening and put results in Power BI. I tried to use pyRevit Run but unfortunately I wasn't capable of doing it - therefore I used RBP.

@jmcouffin
Copy link
Contributor Author

jmcouffin commented Feb 10, 2021 •
edited
Loading

I've looked at it before going into preflight customization, and I understand the need. I'd rather send the data to a gsheet of an online db though for practical reasons: no need to update the pbi ou google datastudio as the data would be live linked. That is the way I do it with our qc dynamo script. slightly more streamlined. When should find a way to make the script work with RBP or pyrevit run as well for that matter. Thoughts, @eirannejad ?
You set of tools are fantastic @davidvadkerti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcouffin @eirannejad @davidvadkerti