Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added feature #1341 #1342

Merged
merged 11 commits into from
Oct 25, 2021
Merged

added feature #1341 #1342

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c950319
Merge branch 'art' into master
eirannejad Aug 30, 2020
5ac15c8
fixed host adder and added 2020.2.3
eirannejad Sep 11, 2020
4319ff0
added 2020.1.1 to hosts
eirannejad Sep 22, 2020
738cac0
Merge branch 'develop'
eirannejad Nov 9, 2020
92cb346
Merge branch 'develop'
eirannejad Nov 21, 2020
6f3e004
Merge branch 'develop'
eirannejad Feb 2, 2021
9eb5df2
Merge branch 'develop'
eirannejad Mar 23, 2021
7eb0a4e
Merge branch 'develop'
eirannejad Apr 4, 2021
b074f29
Merge branch 'develop'
eirannejad May 17, 2021
b765b3c
added feature #1341
dosymep Sep 29, 2021
0039c51
fixed indent
dosymep Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions pyrevitlib/pyrevit/extensions/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,21 @@ def get_target_assembly(self, required=False):
assm_file = self.assembly.lower()
if not assm_file.endswith(framework.ASSEMBLY_FILE_TYPE):
assm_file += '.' + framework.ASSEMBLY_FILE_TYPE
target_asm = self.find_bundle_module(assm_file)
if not target_asm and required:
mlogger.error("%s can not find target assembly.", self)

# try get assembly with revit version (RevitPlugin_2020.dll)
new_assm_file = self.get_assm_file(assm_file)
target_asm = self.find_bundle_module(new_assm_file)
if not target_asm:
# get default assembly version (RevitPlugin.dll)
target_asm = self.find_bundle_module(assm_file)
if not target_asm and required:
mlogger.error("%s can not find target assembly.", self)

return target_asm or ''

def get_assm_file(self, assm_file):
return os.path.splitext(assm_file)[0] + '_' + HOST_APP.version + \
'.' + framework.ASSEMBLY_FILE_TYPE

class LinkButton(NoScriptButton):
type_id = exts.LINK_BUTTON_POSTFIX
Expand Down