Sort revisions before printing revision report #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous script outputs the revision list straight from a FilteredElementCollector, so the list of revisions are not necessarily in numerical order. This change gathers the revision numbers and revision data in a rev_data list prior to adding them to the rev_table string, that way they can be sorted first.
|
📦 New work-in-progress (wip) builds are available for 4.8.12.22246+2301-wip |
|
📦 New work-in-progress (wip) builds are available for 4.8.12.22246+2308-wip |
|
📦 New work-in-progress (wip) builds are available for 4.8.12.22246+2328-wip |
sanzoghenzo
pushed a commit
to sanzoghenzo/pyRevit
that referenced
this pull request
Jan 20, 2023
The previous script outputs the revision list straight from a FilteredElementCollector, so the list of revisions are not necessarily in numerical order. This change gathers the revision numbers and revision data in a rev_data list prior to adding them to the rev_table string, that way they can be sorted first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous script outputs the revision list straight from a FilteredElementCollector, so the list of revisions is not necessarily in numerical order. This change gathers the revision numbers and revision data in a rev_data list prior to adding them to the rev_table string, that way they can be sorted first.