Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1705 #1781

Merged
merged 1 commit into from
Apr 3, 2023
Merged

#1705 #1781

merged 1 commit into from
Apr 3, 2023

Conversation

nodatasheet
Copy link
Contributor

This PR is to address the issue #1705

@nodatasheet
Copy link
Contributor Author

Tested in IPY277 and IPY340 on Revit 2023 | Version: 23.1.10.4

@nodatasheet nodatasheet marked this pull request as ready for review April 3, 2023 10:33
@jmcouffin jmcouffin added Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Prioritize The issue is planned to be resolved in the next version Engines Issues related to pyRevit execution engines [subsystem] labels Apr 3, 2023
@jmcouffin jmcouffin merged commit 2758d8a into pyrevitlabs:develop Apr 3, 2023
@jmcouffin
Copy link
Contributor

thanks for tis one @nodatasheet
Like mentioned by @thumDer there might be quite a few other instances of the same issue with the hasattr

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23093+1230-wip

@nodatasheet
Copy link
Contributor Author

Hey guys!

The problem is that hasattr is quite a popular function and rough search gives us ~460 results in the project 😝

image

Any hint on how to filter the one we're after?

@jmcouffin @thumDer

@jmcouffin
Copy link
Contributor

@nodatasheet yep, I would concentrate on the use within the pyrevitlib section and in pyrevit tools and not so much in the site-packages section
for now

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23096+0757-wip

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23096+0908-wip

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23096+0944-wip

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23096+2210-wip

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23097+1931-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23104+0950-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23108+1109-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23110+0800-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23111+0822-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23114+0751-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23114+0900-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23117+1019-wip

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23122+0740-wip

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23126+1635-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23131+1009-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23137+0756-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23137+0809-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23139+0632-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0857-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0943-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0957-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+1030-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23161+1332-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0849-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0858-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0910-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0908-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1046-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1150-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1153-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23164+0946-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23165+1014-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23166+0843-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+0833-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1018-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1041-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23177+1038-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23181+1652-wip

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

📦 New public release are available for 4.8.13.23182+2215

@nodatasheet nodatasheet deleted the 1705 branch September 8, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Engines Issues related to pyRevit execution engines [subsystem] Prioritize The issue is planned to be resolved in the next version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nodatasheet @jmcouffin