Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joris van der Meulen > patch forms init #2135

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

3Pinter
Copy link
Contributor

@3Pinter 3Pinter commented Mar 4, 2024

Some elements (like parts) don't have types. Forms.select_parameters will crash upon feeding such elements.

(forum post)

added Line 2685 if src_type is not None
scr_type can be None if no type is present.
(Parts don't have Type for instance which will break the code.)
@jmcouffin jmcouffin changed the base branch from develop-4 to develop March 4, 2024 16:02
@jmcouffin jmcouffin changed the base branch from develop to develop-4 March 4, 2024 16:02
@jmcouffin jmcouffin added the Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] label Mar 4, 2024
@jmcouffin
Copy link
Contributor

Good to go!
Well done @3Pinter

@jmcouffin jmcouffin merged commit 45afa37 into pyrevitlabs:develop-4 Mar 4, 2024
Copy link
Contributor

📦 New public release are available for 4.8.15.24089+0912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants