Obsolete IntegerValue property in Revit2024 and higher - Replaced by Value

extensions/pyRevitTags.extension/lib/pkgmgr.py

@@ -6,6 +6,7 @@
 from pyrevit import coreutils
 from pyrevit.coreutils import logger
 from pyrevit import revit, DB
+from pyrevit.compat import get_value_func
 
 from pkgcommits import CommitPointTypes, CommitTypes
 from pkgcommits import CommitPoint, Commit, CommitHistory
@@ -68,11 +69,9 @@ def _read_commit_history(self, commit_cfg):
                     mlogger.debug(self._chistory)
 
         # process revisions
-        sheet_revids = \
-            {x.IntegerValue for x in self.revit_sheet.GetAllRevisionIds()}
-        add_sheet_revids = \
-            {x.IntegerValue
-             for x in self.revit_sheet.GetAdditionalRevisionIds()}
+        value_func = get_value_func()
+        sheet_revids = {value_func(x) for x in self.revit_sheet.GetAllRevisionIds()}
+        add_sheet_revids = {value_func(x) for x in self.revit_sheet.GetAdditionalRevisionIds()}
         readonly_sheet_revids = sheet_revids - add_sheet_revids
 
         default_rev_commit_type = CommitPointTypes.Revision.default_commit_type
@@ -153,6 +152,7 @@ def get_commit_points():
     commit_points = []
     # grab defined packages
     dockpkgs = []
+    value_func = get_value_func()
     docpkg_finder = \
         re.compile(r'docpkg(\d+)\s*[-_]*?\s*(.+)', flags=re.IGNORECASE)
     for project_param in revit.query.get_project_parameters(doc=revit.doc):
@@ -167,7 +167,6 @@ def get_commit_points():
         elif 'docpkg' in project_param.name.lower():
             mlogger.warning('Package parameter "%s" is not formatted '
                             'correctly and is skipped.', project_param.name)
-
     last_docpkg_idx = -1
     for idx, docpkg in enumerate(sorted(dockpkgs, key=lambda x: x.pkg_idx)):
         last_docpkg_idx = idx
@@ -185,7 +184,7 @@ def get_commit_points():
                      key=lambda x: x.SequenceNumber)
     commit_points.extend([
         CommitPoint(cptype=CommitPointTypes.Revision,
-                    target=x.Id.IntegerValue,
+                    target=value_func(x.Id),
                     idx=last_docpkg_idx + i + 1,
                     name='R{}'.format(x.SequenceNumber),
                     desc='{}{} (Sequence #{})'.format(
@@ -195,7 +194,6 @@ def get_commit_points():
                         x.SequenceNumber))
         for i, x in enumerate(docrevs)
         ])
-
     sorted_cpoints = sorted(commit_points, key=lambda x: x.idx)
     mlogger.debug(sorted_cpoints)
     return sorted_cpoints

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Inspect.pulldown/LinesPerViewCounter.pushbutton/LinesPerViewCounter_script.py

@@ -3,6 +3,7 @@
 
 from pyrevit import script
 from pyrevit import revit, DB
+from pyrevit.compat import get_value_func
 
 
 __title__ = 'Lines Per View Counter'
@@ -40,7 +41,8 @@ def line_count(document=doc):
         lines = DB.FilteredElementCollector(document).OfCategory(DB.BuiltInCategory.OST_Lines).WhereElementIsNotElementType().ToElements()
         for line in lines:
             if line.CurveElementType.ToString() == "DetailCurve":
-                view_id_int = line.OwnerViewId.IntegerValue
+                value_func = get_value_func()
+                view_id_int = value_func(line.OwnerViewId)
                 detail_lines[view_id_int] += 1
         for line_count, view_id_int \
                 in sorted(zip(detail_lines.values(), detail_lines.keys()),

pyrevitlib/pyrevit/compat.py

@@ -11,7 +11,7 @@
 
 PY2 = sys.version_info[0] == 2
 PY3 = sys.version_info[0] == 3
-IRONPY2711 = sys.version_info[:3] == (2, 7, 11)
+IRONPY2712 = sys.version_info[:3] == (2, 7, 12)
 IRONPY340 = sys.version_info[:3] == (3, 4, 0)
 
 #pylint: disable=import-error,unused-import
@@ -58,6 +58,35 @@ def is_netcore():
     safe_strtype = lambda x: unicode(x)  #pylint: disable=E0602,unnecessary-lambda
 
 
+def get_value_func():
+        """Determines and returns the appropriate value extraction function based on the host application's version.
+
+        Returns:
+            function: A function that takes an item as an argument and returns its value. 
+                      If the host application version is newer than 2023, it returns the `get_value_2024` function, 
+                      which extracts the `Value` attribute from the item. 
+                      Otherwise, it returns the `get_value_2003` function, which extracts the `IntegerValue` attribute from the item.
+
+        Functions:
+            get_value_2024(item): Extracts the `Value` attribute from the given item.
+            get_value_2003(item): Extracts the `IntegerValue` attribute from the given item.
+
+        Examples:
+            ```python
+            value_func = get_value_func()
+            sheet_revids = {value_func(x) for x in self.revit_sheet.GetAllRevisionIds()}
+            add_sheet_revids = {value_func(x) x in self.revit_sheet.GetAdditionalRevisionIds()}
+            ```
+        """
+        def get_value_2024(item):
+            return item.Value
+
+        def get_value_2003(item):
+            return item.IntegerValue
+
+        return get_value_2024 if __revit__.Application.is_newer_than(2023) else get_value_2003
+
+
 def urlopen(url):
     """Urlopen wrapper.
 

pyrevitlib/pyrevit/output/linkmaker.py

@@ -1,6 +1,6 @@
 """Handle creation of output window helper links."""
 
-from pyrevit.compat import safe_strtype
+from pyrevit.compat import safe_strtype, get_value_func
 from pyrevit import DB
 from pyrevit.coreutils.logger import get_logger
 
@@ -48,11 +48,12 @@ def make_link(element_ids, contents=None):
             print('{}: {}'.format(idx+1, output.linkify(elid)))
         ```
     """
+    value_func = get_value_func()
     try:
         try:
-            strids = [safe_strtype(x.IntegerValue) for x in element_ids]
+            strids = [safe_strtype(value_func(x)) for x in element_ids]
         except TypeError:
-            strids = [safe_strtype(element_ids.IntegerValue)]
+            strids = [safe_strtype(value_func(element_ids))]
     except AttributeError:
         raise ValueError("One or more items are not ElementIds")
 

pyrevitlib/pyrevit/revit/db/create.py

@@ -8,6 +8,7 @@
 from pyrevit.coreutils.logger import get_logger
 from pyrevit import DB
 from pyrevit.revit.db import query
+from pyrevit.compat import get_value_func
 
 
 #pylint: disable=W0703,C0302,C0103
@@ -290,13 +291,12 @@ def create_revision_sheetset(revisions,
     # find revised sheets
     myviewset = DB.ViewSet()
     check_func = any if match_any else all
+    value_func = get_value_func()
     for sheet in sheets:
         revs = sheet.GetAllRevisionIds()
-        sheet_revids = [x.IntegerValue for x in revs]
-        if check_func([x.Id.IntegerValue in sheet_revids
-                       for x in revisions]):
-            myviewset.Insert(sheet)
-
+        sheet_revids = [value_func(x) for x in revs]
+        if check_func([value_func(x.Id) in sheet_revids for x in revisions]):
+                myviewset.Insert(sheet)
     # needs transaction
     # delete existing sheet set if any
     # create new sheet set
@@ -404,6 +404,7 @@ def create_param_value_filter(filter_name,
         DB.LogicalOrFilter if match_any else DB.LogicalAndFilter
 
     # create the rule set
+    value_func = get_value_func()
     for pvalue in param_values:
         # grab the evaluator
         param_eval = PARAM_VALUE_EVALUATORS.get(evaluator, None)
@@ -436,14 +437,15 @@ def create_param_value_filter(filter_name,
                                             str(pvalue),
                                             False)
             elif isinstance(pvalue, DB.ElementId):
+                p_id = str(value_func(pvalue))
                 if HOST_APP.is_newer_than(2022):
                     rule = DB.FilterStringRule(param_prov,
                                             num_eval(),
-                                            str(pvalue.IntegerValue))
+                                            p_id)
                 else:
                     rule = DB.FilterStringRule(param_prov,
                                             num_eval(),
-                                            str(pvalue.IntegerValue),
+                                            p_id,
                                             False)
         # if value is int, eval is expected to be numeric
         elif isinstance(pvalue, int):

pyrevitlib/pyrevit/revit/db/query.py

@@ -9,7 +9,7 @@
 from pyrevit import api
 from pyrevit import framework
 from pyrevit import compat
-from pyrevit.compat import PY3, safe_strtype
+from pyrevit.compat import PY3, safe_strtype, get_value_func
 from pyrevit import DB
 from pyrevit.revit import db
 from pyrevit.revit import features
@@ -760,9 +760,10 @@ def get_schedule_categories(doc=None):
     doc = doc or DOCS.doc
     all_cats = get_doc_categories(doc)
     cats = []
+    value_func = get_value_func()
     for cat_id in DB.ViewSchedule.GetValidCategoriesForSchedule():
         for cat in all_cats:
-            if cat.Id.IntegerValue == cat_id.IntegerValue:
+            if value_func(cat.Id) == value_func(cat_id):
                 cats.append(cat)
     return cats
 
@@ -771,9 +772,10 @@ def get_key_schedule_categories(doc=None):
     doc = doc or DOCS.doc
     all_cats = get_doc_categories(doc)
     cats = []
+    value_func = get_value_func()
     for cat_id in DB.ViewSchedule.GetValidCategoriesForKeySchedule():
         for cat in all_cats:
-            if cat.Id.IntegerValue == cat_id.IntegerValue:
+            if value_func(cat.Id) == value_func(cat_id):
                 cats.append(cat)
     return cats
 
@@ -782,9 +784,10 @@ def get_takeoff_categories(doc=None):
     doc = doc or DOCS.doc
     all_cats = get_doc_categories(doc)
     cats = []
+    value_func = get_value_func()
     for cat_id in DB.ViewSchedule.GetValidCategoriesForMaterialTakeoff():
         for cat in all_cats:
-            if cat.Id.IntegerValue == cat_id.IntegerValue:
+            if value_func(cat.Id) == value_func(cat_id):
                 cats.append(cat)
     return cats
 
@@ -797,8 +800,9 @@ def get_category(cat_name_or_builtin, doc=None):
             if cat.Name == cat_name_or_builtin:
                 return cat
     elif isinstance(cat_name_or_builtin, DB.BuiltInCategory):
+        value_func = get_value_func()
         for cat in all_cats:
-            if cat.Id.IntegerValue == int(cat_name_or_builtin):
+            if value_func(cat.Id) == int(cat_name_or_builtin):
                 return cat
     elif isinstance(cat_name_or_builtin, DB.Category):
         return cat_name_or_builtin
@@ -807,12 +811,13 @@ def get_category(cat_name_or_builtin, doc=None):
 def get_builtincategory(cat_name_or_id, doc=None):
     doc = doc or DOCS.doc
     cat_id = None
+    value_func = get_value_func()
     if isinstance(cat_name_or_id, str):
         cat = get_category(cat_name_or_id)
         if cat:
-            cat_id = cat.Id.IntegerValue
+            cat_id = value_func(cat.Id)
     elif isinstance(cat_name_or_id, DB.ElementId):
-        cat_id = cat_name_or_id.IntegerValue
+        cat_id = value_func(cat_name_or_id)
     if cat_id:
         for bicat in DB.BuiltInCategory.GetValues(DB.BuiltInCategory):
             if int(bicat) == cat_id:
@@ -823,16 +828,16 @@ def get_subcategories(doc=None, purgable=False, filterfunc=None):
     doc = doc or DOCS.doc
     # collect custom categories
     subcategories = []
+    value_func = get_value_func()
     for cat in doc.Settings.Categories:
         for subcat in cat.SubCategories:
             if purgable:
-                if subcat.Id.IntegerValue > 1:
+                if value_func(subcat.Id) > 1:
                     subcategories.append(subcat)
             else:
                 subcategories.append(subcat)
     if filterfunc:
         subcategories = filter(filterfunc, subcategories)
-
     return subcategories
 
 
@@ -848,10 +853,14 @@ def get_subcategory(cat_name_or_builtin, subcategory_name, doc=None):
 def get_builtinparameter(element, param_name, doc=None):
     doc = doc or DOCS.doc
     eparam = element.LookupParameter(param_name)
+    value_func = get_value_func()
     if eparam:
+        eparam_def_id = value_func(eparam.Definition.Id)
         for biparam in DB.BuiltInParameter.GetValues(DB.BuiltInParameter):
-            if int(biparam) == eparam.Definition.Id.IntegerValue:
+            if int(biparam) == eparam_def_id:
                 return biparam
+    else:
+        raise PyRevitException('Parameter not found: {}'.format(param_name))
 
 
 def get_view_cutplane_offset(view):
@@ -1576,6 +1585,7 @@ def get_geometry(element, include_invisible=False, compute_references=False):
     geom_opts.IncludeNonVisibleObjects = include_invisible
     geom_opts.ComputeReferences = compute_references
     geom_objs = []
+    value_func = get_value_func()
     try:
         for gobj in element.Geometry[geom_opts]:
             if isinstance(gobj, DB.GeometryInstance):
@@ -1585,5 +1595,5 @@ def get_geometry(element, include_invisible=False, compute_references=False):
                 geom_objs.append(gobj)
         return geom_objs
     except TypeError:
-        mlogger.debug("element %s has no geometry", element.Id.IntegerValue)
+        mlogger.debug("element %s has no geometry", value_func(element.Id))
         return

pyrevitlib/pyrevit/revit/db/update.py

@@ -5,6 +5,7 @@
 from pyrevit.framework import List
 from pyrevit import DB
 from pyrevit.revit.db import query
+from pyrevit.compat import get_value_func
 
 
 def set_name(element, new_name):
@@ -20,28 +21,26 @@ def set_name(element, new_name):
 
 def update_sheet_revisions(revisions, sheets=None, state=True, doc=None):
     doc = doc or DOCS.doc
+    value_func = get_value_func()
     # make sure revisions is a list
     if not isinstance(revisions, list):
         revisions = [revisions]
-
     updated_sheets = []
     if revisions:
         # get sheets if not available
         for sheet in sheets or query.get_sheets(doc=doc):
-            addrevs = set([x.IntegerValue
+            addrevs = set([value_func(x)
                            for x in sheet.GetAdditionalRevisionIds()])
             for rev in revisions:
                 # skip issued revisions
                 if not rev.Issued:
                     if state:
-                        addrevs.add(rev.Id.IntegerValue)
-                    elif rev.Id.IntegerValue in addrevs:
-                        addrevs.remove(rev.Id.IntegerValue)
-
+                        addrevs.add(value_func(rev.Id))
+                    elif value_func(rev.Id) in addrevs:
+                        addrevs.remove(value_func(rev.Id))
             rev_elids = [DB.ElementId(x) for x in addrevs]
             sheet.SetAdditionalRevisionIds(List[DB.ElementId](rev_elids))
             updated_sheets.append(sheet)
-
     return updated_sheets
 
 

pyrevitlib/rpw/db/builtins.py

@@ -18,6 +18,7 @@
 from rpw.base import BaseObject, BaseObjectWrapper
 from rpw.utils.dotnet import Enum
 from rpw.exceptions import RpwCoerceError
+from pyrevit.compat import get_value_func
 
 
 class _BiParameter(BaseObjectWrapper):
@@ -155,8 +156,10 @@ def from_category_id(self, category_id):
         Returns:
             ``DB.BuiltInCategory`` member
         """
-        bic = Enum.ToObject(DB.BuiltInCategory, category_id.IntegerValue)
-        if DB.ElementId(bic).IntegerValue < -1:
+        value_func = get_value_func()
+        bic = Enum.ToObject(DB.BuiltInCategory, value_func(category_id))
+        bic_value = value_func(DB.ElementId(bic))
+        if bic_value < -1:
             return bic
         else:
             # If you pass a regular element to category_id, it converts it to BIC.

pyrevitlib/rpw/db/family.py

@@ -29,6 +29,7 @@
 from rpw.utils.mixins import CategoryMixin
 from rpw.db.builtins import BicEnum
 from rpw.db.category import Category
+from pyrevit.compat import get_value_func
 
 
 class FamilyInstance(Element, CategoryMixin):
@@ -93,7 +94,9 @@ def in_assembly(self):
         Returns:
             (bool): True if element is inside an AssemblyInstance
         """
-        if self._revit_object.AssemblyInstanceId.IntegerValue == -1:
+        value_func = get_value_func()
+        assembly_id_value = value_func(self._revit_object.AssemblyInstanceId)
+        if assembly_id_value == -1:
             return False
         else:
             return True