Fixes to work with translated Revit; minor improvements #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from upstream
eirannejad
approved these changes
Jun 2, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 2, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 2, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 2, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 2, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 2, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 2, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 2, 2019
added logger back. It's better to have the logger object so one can add log messages easily without going back to the top of script to check if logger object exists
eirannejad
added a commit
that referenced
this pull request
Jun 2, 2019
|
|
@melnikovalex Does your test model return a from pyrevit improt revit
revit.query.get_category(DB.BuiltInCategory.OST_Truss) |
eirannejad
added a commit
that referenced
this pull request
Jun 11, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 11, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 11, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 11, 2019
eirannejad
added a commit
that referenced
this pull request
Jun 11, 2019
It returns For OST_Walls works normally |
|
@melnikovalex Ran a search and apparently there is a lot of them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Framework imporvements:
7641f7a Support BuiltInCategories in script
__context__There used to be a couple of scripts (Override Dims/Texts) which were using English category name in a
__context__. That was making those button always unavailable in non-English Revit. Now it is considering strings started fromOST_as a BuiltInCategory name.Fixes to work with translated Revit:
7e15da6 Find Referencing Views
97b1b86 Views tools:
f72432a Sheet tools
cbf469c Override VG
e2830f0 Overrides scripts (Dimension, Text)
a5fa8dc Elements of selected Level
bcd15dd Pick tool
UI improvements:
47310ce and c3ac17a CommandSwitchWindow new option: RecognizeAccessKey
There were a problem: CommandSwitchWindow was swallowing first underscore in button names (e.g. with type names it was
ARCDoor_1instead ofARC_Door_1)There are two commits. 47310ce First I was trying to make it possible to set this options for some of the switches, but it was looking too ugly. c3ac17a Finally it is possible to set this options for whole form.
Misc pyRevit tools imporvements ba676d2
Clean ups 46f7aaa