-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readthedocs page #466
Conversation
"numpyro>=0.2.4", | ||
"jax>=0.1.57", | ||
"jaxlib>=0.1.37", | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fritzo Do you have a config file for black? I run make format
but it causes a lot of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our only config file is setup.cfg but we do not configure black. Maybe you need to update isort, whose black support was added only in 5.0?
pip install -U isort black flake8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the packages. I am not sure what is the default behavior but it seems to me the changes here look more consistent with what I think black
will do. For example,
params = {
"eps_g": {},
"eps_i": {},
}
should be in 1 line
params = {"eps_g": {}, "eps_i": {}}
if it fits into an 88-length (black default line length) line. Anyway, I will revert the changes to not populate this PR, whose current changes might be caused by some mysterious config files in my system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that's weird. I especially don't understand why linting (black --check .
) passed both before and after your black changes e7dc9d1 Does make lint
pass on your system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you are right. black --check .
passed now, and make format
does not change files anymore. It is weird... I guess black supports two formatting rules for parentheses and based on "cache" or something like that, black will behave differently... Anyway, I will revert unrelated changes because make format
seems to work now in my system.
a side note: the current behavior is a bit different from what I understand from How black wraps lines.
update2: yeah, there seems to have two acceptable behaviors for black (also the related issue on how black
deals with trailing commas on list/tuple/dict/...
). Hopefully, there will be a flag in the next black release, that makes the behavior consistent.
@fritzo There are a few black changes remaining, hope that they are fine. I have incorporated (and tested) the following changes that I made to rtd page:
I need to add |
Thanks @fehiepsi, this is great! |
No description provided.