Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jit error in hmm example #1445

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Fix jit error in hmm example #1445

merged 1 commit into from
Oct 15, 2018

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Oct 15, 2018

Addresses #1435

This fixes one bug in the jitted hmm example, but surfaces another bug:

ValueError: Expected all enumerated sample sites to share a common poutine.scale, but found 11 different scales.

@fritzo fritzo requested a review from neerajprad October 15, 2018 17:39
@neerajprad neerajprad merged commit 29a1a2b into pytorch-1.0 Oct 15, 2018
@fritzo fritzo mentioned this pull request Oct 15, 2018
Closed
neerajprad pushed a commit that referenced this pull request Oct 22, 2018
@fritzo @neerajprad
Fix jit arg error in hmm example (#1445)
9230599
@fritzo fritzo deleted the fix-gmm-jit-args branch October 24, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neerajprad neerajprad neerajprad approved these changes

Assignees
No one assigned
Labels
awaiting review WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @neerajprad