-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlanarFlow #1515
PlanarFlow #1515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the pr!
have you used this in some context to fit some distribution?
Do you mean have I tested it out for learning distributions? Or rather, what would be a motivation for including it in the library? I should test it out for learning a simple distribution, although the Jacobian passes... I think it's important to have PlanarFlow because it's a baseline for other flows in the literature, like Sylvester flow |
yes |
Let me test it out before we proceed |
Sorry for the delay! I've been able to learn densities from Table 1/Figure 3 of "Variational Inference with Normalizing Flows" so I'm confident that PlanarFlow works. E.g.: True U1: test_potential.pdf |
I've changed this commit to used the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Software-wise this looks fine to me. @martinjankowiak can you confirm the math is sane 😄
thanks @stefanwebb ! |
Implementation of the simple PlanarFlow (from "Variational inference with normalizing flows")