Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up requirements #1768

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Clean up requirements #1768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a6ee71
clean up requirements
fehiepsi Feb 19, 2019
b25c706
revert numpy requirement
fehiepsi Feb 19, 2019
1a79615
require numpy and observations
fehiepsi Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
sphinx
sphinx_rtd_theme
numpy>=1.7
contextlib2
cloudpickle>=0.3.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpchen can you confirm we no longer need cloudpickle or observations?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep LGTM. besides internal applications, i'm not sure which example was using cloudpickle in the first place...

graphviz>=0.8
observations>=0.1.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is still used in the AIR example from #500
@neerajprad should we move off this dependency ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it seems that I miss that tutorial while using "grep".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed needed by a few tutorials, let us reinstate it back.

opt_einsum>=2.3.2
tqdm>=4.25
tqdm>=4.28
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
EXTRAS_REQUIRE = [
'jupyter>=1.0.0',
'matplotlib>=1.3',
'numpy>=1.7',
'observations>=0.1.4',
'pillow',
'torchvision',
Expand All @@ -83,7 +84,6 @@
# add them to `docs/requirements.txt`
'contextlib2',
'graphviz>=0.8',
'numpy>=1.7',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have removed this if all pytorch builds shipped with numpy. The pytorch pip wheel does not install numpy, but will throw an ImportError without numpy, because there are parts of torch that call numpy. I don't see any harm in keeping this in the requirement since it should anyways be installed with pytorch, and our minimum version requirement is an old one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks @neerajprad !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth adding a comment explaining why we need the numpy requirement, since a code comment is more discoverable than a github comment 😉

'opt_einsum>=2.3.2',
'six>=1.10.0',
'torch>=1.0.0',
Expand Down