Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade scipy dependency for travis tests to pass #1872

Merged
merged 1 commit into from
May 20, 2019

Conversation

neerajprad
Copy link
Member

@neerajprad neerajprad commented May 20, 2019

This enables the travis tests to pass again by using a lower version of scipy that has imresize function used by the AIR tutorial. This is needed until #1871 is fixed.

Copy link
Member

@jpchen jpchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove observations as a dependency

@fehiepsi fehiepsi merged commit 3ac5a02 into pyro-ppl:dev May 20, 2019
@mattwescott
Copy link
Contributor

Built a docker image at 3ac5a02, and it seems to have scipy==1.3 still

make test-examples is giving me cannot import name 'imresize' (#1871) until I manually downgrade.

@neerajprad
Copy link
Member Author

@mattwescott - You will need to manually remove scipy==1.3 first. This change is for our CI, and for users who have not already updated scipy to 1.3. If you already have the latest scipy version, you will need to remove it, and run make install which should pick up the right scipy version that has the imresize function. A permanent fix for this is to remove dependency on the observations library.

@mattwescott
Copy link
Contributor

@neerajprad That makes sense for my native environment, but I'd expect the docker build to emerge with the right version. What am I missing?

@neerajprad
Copy link
Member Author

but I'd expect the docker build to emerge with the right version. What am I missing?

I would expect the same. Could you point me to how you are building the docker image?

@mattwescott
Copy link
Contributor

@neerajprad Rebuilt with --no-cache and got scipy==1.3 again

Looks like it is coming from the other scipy dependency statement in setup.py: b06e5b5#diff-2eeaed663bd0d25b7e608891384b7298R115

@neerajprad
Copy link
Member Author

Looks like it is coming from the other scipy dependency statement in setup.py:

That's my bad, I forgot that we had a dev dependency too. Will rectify it asap. Thanks for pointing out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants