Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TransformReparam compatible with .to_event() #2746

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Make TransformReparam compatible with .to_event() #2746

merged 2 commits into from
Jan 22, 2021

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jan 21, 2021

Addresses an issue from the forum.

This adds our standard Reparam._unwrap() and ._wrap() logic to the TransformReparam()

@fehiepsi can I try to submit a fix to NumPyro too? I'd like to get my hands dirty 😄

Tested

  • generalized an existing unit test

@fritzo fritzo requested a review from fehiepsi January 21, 2021 22:30
@fritzo fritzo mentioned this pull request Jan 21, 2021
Merged
1 task
fehiepsi
fehiepsi approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting your hands into this! LGTM. :D

@fehiepsi fehiepsi merged commit ee084f8 into dev Jan 22, 2021
@fritzo
Copy link
Member Author

fritzo commented Jan 22, 2021

Thanks for reviewing @fehiepsi !

@fritzo fritzo deleted the fix-transform-reparam branch September 27, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
awaiting review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @fehiepsi