Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infer.csis to ignore gradient when parameter not used, which has a gradient of None #2828

Merged
merged 1 commit into from
Apr 28, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyro/infer/csis.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ def loss_and_grads(self, grads, batch, *args, **kwargs):
for site in particle_param_capture.trace.nodes.values())
guide_grads = torch.autograd.grad(particle_loss, guide_params, allow_unused=True)
for guide_grad, guide_param in zip(guide_grads, guide_params):
if guide_grad is None:
continue
guide_param.grad = guide_grad if guide_param.grad is None else guide_param.grad + guide_grad

loss += torch_item(particle_loss)
Expand Down