Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PyTorch 1.9.0 #2887

Merged
merged 12 commits into from
Jul 2, 2021
Merged

Update to PyTorch 1.9.0 #2887

merged 12 commits into from
Jul 2, 2021

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jun 26, 2021

Addresses #2886

@fritzo fritzo added the WIP label Jun 26, 2021
@fritzo fritzo added this to the 1.7 release milestone Jun 29, 2021
@fritzo
Copy link
Member Author

fritzo commented Jul 1, 2021

@eb8680 @ordabayevy I'm seeing some failures when updating Pyro to use funsor master:

pytest tests/contrib/funsor/test_vectorized_markov.py::test_model_enumerated_elbo
...
AttributeError: module 'funsor.sum_product' has no attribute 'dynamic_partial_sum_product'

Can you please advise on how to update this test or the usage?

@ordabayevy
Copy link
Member

Hi @fritzo . dynamic_partial_sum_product was added in the very last commit to the funsor master branch and is used by TraceMarkovEnum_ELBO with new tests in test_vectorized_markov.py. Maybe make a funsor release first? Otherwise we will have to change back TraceMarkovEnum_EBLO and disable some tests.

@fritzo
Copy link
Member Author

fritzo commented Jul 1, 2021

Thanks @ordabayevy, it looks like my funsor master branch was just stale; I've updated and pushed and hopefully things should work now 🤞

@fritzo fritzo added awaiting review and removed WIP labels Jul 2, 2021
@fritzo fritzo marked this pull request as ready for review July 2, 2021 03:36
@fritzo fritzo requested review from neerajprad and eb8680 July 2, 2021 03:36
@fritzo
Copy link
Member Author

fritzo commented Jul 2, 2021

Could either @eb8680 or @neerajprad review this please?

@eb8680
Copy link
Member

eb8680 commented Jul 2, 2021

LGTM assuming the Funsor release didn't break anything

@eb8680 eb8680 merged commit fec3112 into dev Jul 2, 2021
@fritzo
Copy link
Member Author

fritzo commented Jul 2, 2021

Thanks @eb8680!

@fritzo fritzo deleted the pytorch-1.9 branch September 27, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants