Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update enumeration tutorial #2892

Merged
merged 2 commits into from
Jul 4, 2021
Merged

Update enumeration tutorial #2892

merged 2 commits into from
Jul 4, 2021

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jul 2, 2021 •
edited
Loading

Resolves #2875

This updates the enumeration and tensor shapes tutorials with:

Thanks to @samuelklee for providing an example model.

Tested

  • ran make tutorial locally and examined results

@fritzo fritzo added this to the 1.7 release milestone Jul 2, 2021
@fritzo fritzo requested review from eb8680 and ordabayevy July 2, 2021 20:28
ordabayevy
ordabayevy approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@ordabayevy ordabayevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM @fritzo!

@eb8680 eb8680 merged commit 4c07f52 into dev Jul 4, 2021
@eb8680 eb8680 deleted the update-enum-tutorial branch July 4, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordabayevy ordabayevy ordabayevy approved these changes

@eb8680 eb8680 eb8680 approved these changes

Assignees
No one assigned
Labels
awaiting review Examples
Projects
None yet
Milestone
1.7 release
Development

Successfully merging this pull request may close these issues.

How to index into a batch dimension using an enumerated index?
3 participants
@fritzo @eb8680 @ordabayevy