-
-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AutoGaussian and tests #2948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
eb8680
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good per zoom review
Thanks for reviewing @eb8680 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2813
Blocking #2946
Blocked by #2952
This fixes a number of bugs in
AugoGaussian
and two bugs in tests that were silencing the bugs inAutoGaussian
.Fixes & tests
test_backend_dispatch
tests.autoguide.test_gaussian.check_structure()
.Hand mutation-tested that
check_structure()
is now strict.Fixed a number of expected sparsity structure matrices and manually verified changes.
prototype_trace
missing observation nodes and added regression tests checkingguide.dependencies
pyrocov_model_relaxed
from Update to use funsor's SRIF Gaussian #2943 which had been failing due to singular gradient.Remaining errors
pytest tests/infer/test_autoguide.py -k exact --stage=funsor
pytest tests/infer/autoguide/test_gaussian.py -k structure