Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial on Bayesian workflow, with a SARS-CoV-2 running example #2977

Merged
merged 30 commits into from
Mar 3, 2022

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Dec 6, 2021

open in colab

This also adds the helper utility

  • pyro.ops.special.sparse_multinomial_likelihood

@martinjankowiak
Copy link
Collaborator

martinjankowiak commented Dec 13, 2021

comments:

  • typo: intellitently
  • toc entry six missing closing ); alternatively change to colon
  • MCMC is mentioned in overview but not elsewhere. remove?
  • nit: "PANGO lineages of samples" +genomic
  • "should lead to an approximately block diagonal covariance matrix" this is ambiguous. you mean "... in the approximate posterior... when using a mvn variational distribution" or something
  • "While in principle you could be Bayesian about everything, it's best to focus probabilistic inference on the truly uncertain parts of your problem." out of context, remove?
  • 5.5 / dataset["time_step_days"] should be inverted
  • more comments/description of model? or explicitly defer/link to intro logistic growth tutorial?
  • explain 0.01?
  • nit: "is implausibly narrow" => "may be"
  • "...is less sensitive to reparametrization." maybe +"w.r.t. interpreting the results of inference or something?" optimization performance is affected in both cases
  • more text to make the way you move between log/exp space more clear? "most mutations have very little effect"
  • typo: initialzing
  • typo: wavely
  • nit: HaarReparam +"(where appropriate)"?
  • "Try combining multiple guides" => +"using"
  • some sort of concluding sentence?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fritzo
Copy link
Member Author

fritzo commented Mar 3, 2022

Thanks for the detailed review @martinjankowiak, I've tried to address all your review comments.

@martinjankowiak
Copy link
Collaborator

martinjankowiak commented Mar 3, 2022

looks great!

  • typo: its's
  • typo: multiplicitave
  • missing word: we'll need duplicate
  • typo: space,,
  • typo: langauges
  • typo: initialzation

@fritzo
Copy link
Member Author

fritzo commented Mar 3, 2022

done

@martinjankowiak martinjankowiak merged commit d5b0545 into dev Mar 3, 2022
@fritzo fritzo deleted the workflow-tutorial branch March 17, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants