-
-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bound partial for python 3.10 #3101
Conversation
For some reason, the change is failing for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Valiant effort solving this @fehiepsi!
One thing to keep in mind is that classes with __slots__
might not be pickleable (they weren't in Python 2, and I'm not sure if that's been fixed in Python 3). Let's keep an eye out for new pickling errors this might introduce.
Are there plans to put out a new release with these changes anytime soon? Looks like the latest release 1.8.1. still doesn't support python 3.10. |
Hi @Balandat sure we can push out a release this week. Thanks for the ping |
@Balandat just released Pyro 1.8.2. |
Woohoo, thanks! Great customer service! Where do I leave my yelp review? |
Fixes #3095 and resolves #3018.
In Python <= 3.9,
_bound_partial(_bound_partial(f)).func != f
but for some reasons, they are the same in Python 3.10. This PR tries to address such issue by registeringfunc
as a slot of_bound_partial
.