Deprecate CorrLCholeskyTransform in favor of upstream CorrCholeskyTransform
#3199
Conversation
ordabayevy
changed the title
CorrLCholeskyTransform in favor of upstreamCorrCholeskyTransformCorrLCholeskyTransform in favor of upstream CorrCholeskyTransform
| @@ -171,7 +165,6 @@ def iterated(repeats, base_fn, *args, **kwargs): | |||
| "ConditionalRadial", | |||
| "ConditionalSpline", | |||
| "ConditionalSplineAutoregressive", | |||
| "CorrLCholeskyTransform", | |||
There was a problem hiding this comment.
Shouldn't the new CorrCholeskyTransform apper in this list?
There was a problem hiding this comment.
It should be added along with other PyTorch transforms below:
__all__.extend(torch_transforms)
| @@ -32,7 +32,7 @@ | |||
| from .block_autoregressive import BlockAutoregressive, block_autoregressive | |||
| from .cholesky import ( | |||
| CholeskyTransform, | |||
| CorrLCholeskyTransform, | |||
There was a problem hiding this comment.
I'd lean towards preserving the old import so as to avoid breaking existing code, but I'll defer to your judgement if you think we should delete both. (I think of "deprecation" as meaning "it still works but we no longer recommend it", whereas removing from __init__.py would be a truly breaking change)
There was a problem hiding this comment.
Yeah, I think it makes sense to leave the old import.
|
|
||
| from .. import constraints | ||
|
|
||
|
|
||
| def _vector_to_l_cholesky(z): |
| @@ -32,7 +32,7 @@ | |||
| from .block_autoregressive import BlockAutoregressive, block_autoregressive | |||
| from .cholesky import ( | |||
| CholeskyTransform, | |||
| CorrLCholeskyTransform, | |||
There was a problem hiding this comment.
Yeah, I think it makes sense to leave the old import.
| @@ -171,7 +165,6 @@ def iterated(repeats, base_fn, *args, **kwargs): | |||
| "ConditionalRadial", | |||
| "ConditionalSpline", | |||
| "ConditionalSplineAutoregressive", | |||
| "CorrLCholeskyTransform", | |||
There was a problem hiding this comment.
It should be added along with other PyTorch transforms below:
__all__.extend(torch_transforms)
|
Hi @fritzo. Can you have another look at this PR? |
Closes #3181