Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
this PR corrects and improves the plots in the Pyro VAE tutorial.
There seem to be three minor hiccups in the code:
size
argument here does not exist in the current seaborn version anymore and raises an error.plot_llk
, but only the test ELBO values are plotted. I guess this is not intended.The PR plots both train and test performance and ensures ELBOs are correctly aligned with the epochs (even if ELBOs are computed at different frequencies) and moves the plotting function call into the if statement when the data is actually evaluated on the test data.
I did not open a PR because this is a minor correction -- hope that's fine with you.
New example plot: