Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenate torch docstrings at end of distribution wrappers #3246

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jul 24, 2023

Fixes #3243

This builds on @rtviii's PR and fixes errors:

  • skips torch.py in doctest
  • does some string munging to fix indentation
  • removes pytorch xdoctest cruft
  • fixes forecaster docstring error

@rtviii feel free to merge this into your branch, or we can merge this PR directly, either is fine 🙂 Thanks for contributing!

For reviewers

Before this PR
image

After this PR
image

@rtviii
Copy link
Contributor

rtviii commented Jul 25, 2023

Thank you for the awesome package.

Copy link
Collaborator

@martinjankowiak martinjankowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm do you have a link to a rendered version of this?

@fritzo
Copy link
Member Author

fritzo commented Jul 25, 2023

@martinjankowiak I've added docs links and screenshots to the PR description.

@martinjankowiak
Copy link
Collaborator

@fritzo awesome should i go ahead and merge?

@fritzo
Copy link
Member Author

fritzo commented Jul 25, 2023

Yes, @martinjankowiak could you please merge and I'll continue working towards the 1.8.6 release?

@martinjankowiak martinjankowiak merged commit 08902d6 into dev Jul 25, 2023
@fritzo fritzo deleted the rtviii-dev branch August 10, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants