Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handlers explicitly #3285

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Add handlers explicitly #3285

merged 3 commits into from
Oct 24, 2023

Conversation

ordabayevy
Copy link
Member

@ordabayevy ordabayevy commented Oct 22, 2023 •
edited
Loading

Addresses #3284

This should also improve the documentation by displaying handler args in https://docs.pyro.ai/en/stable/poutine.html

@ordabayevy ordabayevy added the WIP label Oct 22, 2023
@ordabayevy ordabayevy linked an issue Oct 22, 2023 that may be closed by this pull request
Mypy has issues with adding classes to the locals() in pyro.poutine.handlers module #3284
Closed
@ordabayevy ordabayevy changed the title Add handlers manually Add handlers explicitly Oct 22, 2023
fritzo
fritzo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great improvement to usability!

@fritzo fritzo merged commit c605f41 into dev Oct 24, 2023
9 checks passed
@ordabayevy ordabayevy mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

@eb8680 eb8680 Awaiting requested review from eb8680

Assignees
No one assigned
Labels
awaiting review usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mypy has issues with adding classes to the locals() in pyro.poutine.handlers module
2 participants
@ordabayevy @fritzo