CI: properly test min and dev #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks as expected now. The envs with old pin pass, latest fail due to scikit-learn regression, dev passes again as that regression was fixed on sklearn main. I have also updated pins in requirements to reflect the actual minimum (or at least tested minimum). |
martinfleis
commented
Aug 3, 2023
@martinfleis is there a specific issue or PR over in |
|
@jGaboardi I suppose scikit-learn/scikit-learn#26772 |
knaaptime
pushed a commit
to knaaptime/esda
that referenced
this pull request
Aug 4, 2023
* CI: properly test min and dev * better pins * fix nightly index * pin scipy to actual min req * update requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to CI environments to ensure that we check against minimal supported versions as well as against dev versions. That ensures that issues like #254 are caught sooner and that we know it affects only some versions of dependencies.