Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address ShapelyDeprecationWarning The 'type' attribute is... #487

Closed
jGaboardi opened this issue Nov 15, 2022 · 1 comment · Fixed by #488
Closed

address ShapelyDeprecationWarning The 'type' attribute is... #487

jGaboardi opened this issue Nov 15, 2022 · 1 comment · Fixed by #488
Assignees
@jGaboardi
Labels
maintenance

Comments

@jGaboardi
Copy link
Member

We need to address these warnings sooner than later:

/home/runner/work/libpysal/libpysal/libpysal/weights/_contW_lists.py:23: ShapelyDeprecationWarning: The 'type' attribute is deprecated, and will be removed in the future. You can use the 'geom_type' attribute instead.
    if shape.type.lower() == "polygon":
@martinfleis
Copy link
Member

geom_type has been around for a while, so a simple replacement of .type with .geom_type should do the trick,

@jGaboardi jGaboardi self-assigned this Nov 15, 2022
jGaboardi added a commit to jGaboardi/libpysal that referenced this issue Nov 15, 2022
@jGaboardi
resolve pysal#487
6c4ee50
@jGaboardi jGaboardi mentioned this issue Nov 15, 2022
Merged
martinfleis pushed a commit that referenced this issue Nov 15, 2022
@jGaboardi
type vs. geom_type with shapely (#488)
390c5c4 
* resolve #487

* f-string format

* assert correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

type vs. geom_type with shapely jGaboardi/libpysal
2 participants
@jGaboardi @martinfleis