Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addressing DeprecationWarning: fromstring() #132

Merged
merged 6 commits into from
Aug 24, 2019
Merged

addressing DeprecationWarning: fromstring() #132

merged 6 commits into from
Aug 24, 2019

Conversation

jGaboardi
Copy link
Member

The justification for this PR is:

@jGaboardi
Copy link
Member Author

Python3.6, PYSAL_PLUS failing

@jGaboardi
Copy link
Member Author

@sjsrey @sjsrey @weikang9009 @knaaptime

Do any of you have thoughts on this?

@jGaboardi jGaboardi mentioned this pull request Mar 2, 2019
Closed
@jGaboardi jGaboardi self-assigned this Mar 10, 2019
@jGaboardi jGaboardi added enhancement rough edge Something that's not a bug, but that gets in the way of "it just works." WIP Work in progress, do not merge. Discussion only. and removed WIP Work in progress, do not merge. Discussion only. labels Mar 10, 2019
@jGaboardi jGaboardi mentioned this pull request Apr 25, 2019
Closed
@jGaboardi
Copy link
Member Author

#152

ljwolf
ljwolf reviewed Apr 25, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
weikang9009
weikang9009 reviewed Apr 25, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@ljwolf ljwolf added this to the next milestone Jun 25, 2019
@sjsrey sjsrey mentioned this pull request Aug 24, 2019
Closed
sjsrey
sjsrey approved these changes Aug 24, 2019
View reviewed changes
Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sjsrey sjsrey merged commit 1e8d264 into pysal:master Aug 24, 2019
@jGaboardi jGaboardi deleted the depWarn branch August 24, 2019 18:04
@jGaboardi jGaboardi mentioned this pull request Aug 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljwolf ljwolf ljwolf left review comments

@weikang9009 weikang9009 weikang9009 left review comments

@sjsrey sjsrey sjsrey approved these changes

@knaaptime knaaptime Awaiting requested review from knaaptime

Assignees

@jGaboardi jGaboardi

Labels
enhancement rough edge Something that's not a bug, but that gets in the way of "it just works."
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
4 participants
@jGaboardi @sjsrey @ljwolf @weikang9009