-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump supported Python versions and correct lat2SW doctest #154
Conversation
Failure does not appear to be do to the {3.6,3.7} upgrade, but a simple failed doctest. This seems to be an issue with how the
|
Hi @jGaboardi, this seems to be related to NumPy array scalar? After pulling your commits to my local machine and ran doctests locally, I ran into this error: |
The tests for pass locally for me, both for Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
----------------------------------------------------------------------
File "/home/serge/Dropbox/p/pysal/src/subpackages/libpysal/libpysal/weights/util.py", line 1156, in libpysal.weights.util.lat2SW
Failed example:
w9[0,1]
Expected:
array(1, dtype=int8)
Got:
1
The local failures could be due to not replicating the travis envs for the version bump. |
So this is a bit strange, correct? The tests pass on locally (for me) and on Travis for 3.6 and 3.7, but fail for you guys. |
BUG: fix for scipy bump #154
Bumping supporting Python versions in TravisCI to match pysal/pysal#1095
{3.5, 3.6} --> {3.6, 3.7}