Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci #172

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Ci #172

merged 2 commits into from
Jul 31, 2019

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Jul 31, 2019

  1. [X ] You have run tests on this submission, either by using Travis Continuous Integration testing testing or running nosetests on your changes?
  2. [ X] This pull request is directed to the pysal/master branch.
  3. [X ] You have assigned a
    reviewer     and added relevant labels
  4. The justification for this PR is: modernizing travis build

@sjsrey sjsrey requested review from ljwolf and jGaboardi July 31, 2019 04:13
jGaboardi
jGaboardi approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pysal/pysal#1128

@jGaboardi jGaboardi added the bug functionality that: returns invalid, erroneous, or meaningless results; or doesn't work at all. label Jul 31, 2019
@sjsrey sjsrey merged commit dcedc73 into pysal:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

@ljwolf ljwolf Awaiting requested review from ljwolf

Assignees
No one assigned
Labels
bug functionality that: returns invalid, erroneous, or meaningless results; or doesn't work at all.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjsrey @jGaboardi