-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert shapely hard dependecy #454
Conversation
I also had to do some adaptation in tests to make sure they're properly skipped if the required optional dep is missing. |
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
========================================
+ Coverage 78.8% 79.4% +0.6%
========================================
Files 122 122
Lines 12910 12957 +47
========================================
+ Hits 10168 10286 +118
+ Misses 2742 2671 -71
|
Shall we merge or get another review from @sjsrey? |
I should have also checked this before the tag for v4.6.1. Happy to make 4.6.2 ? |
I forgot that it is still there. Yes, I would do 4.6.2 with this. |
on it |
Closes #453
Since this a regression of some sort, I'd recommend issuing 4.6.1 release.
I have also included a CI environment that does not have any optional dependencies so we can catch this issue next time before merging and releasing.